From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com [209.85.208.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6AAD1445320 for ; Mon, 13 Jul 2020 11:35:06 +0300 (MSK) Received: by mail-lj1-f196.google.com with SMTP id e4so16220443ljn.4 for ; Mon, 13 Jul 2020 01:35:06 -0700 (PDT) Date: Mon, 13 Jul 2020 11:35:03 +0300 From: Cyrill Gorcunov Message-ID: <20200713083503.GD296695@grain> References: <094d9d56fcd71a01cd3a9467e81a18fd8608a032.1594486881.git.v.shpilevoy@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <094d9d56fcd71a01cd3a9467e81a18fd8608a032.1594486881.git.v.shpilevoy@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH 1/1] test: fix flaky qsync_basic.test.lua List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org On Sat, Jul 11, 2020 at 07:01:52PM +0200, Vladislav Shpilevoy wrote: > In one of the test cases 2 fibers were started making a > transaction. In the first fiber the transaction was rolled back, > and the second fiber was expected to do the same. > > It did rollback too, but not always immediately after the first > one. Because the first fiber needed not just do rollback right > away, but write a ROLLBACK entry into WAL before applying the > rollback to all next transactions. This led to a yield, during > which it was possible to observe the second fiber not dead yet. > > The patch makes the test explicitly wait for the fibers death. > > Closes #5162 > --- > Branch: http://github.com/tarantool/tarantool/tree/gerold103/gh-5162-flaky-qsync_basic > Issue: https://github.com/tarantool/tarantool/issues/5162 Reviewed-by: Cyrill Gorcunov