From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [217.69.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 9F361445320 for ; Fri, 10 Jul 2020 19:55:36 +0300 (MSK) Date: Fri, 10 Jul 2020 19:55:35 +0300 From: Sergey Bronnikov Message-ID: <20200710165535.GA80670@pony.bronevichok.ru> References: <7b82ce9d-9840-f98a-6d99-38afdeac68d9@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <7b82ce9d-9840-f98a-6d99-38afdeac68d9@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH 5/6] Fix luacheck warnings in src/lua/ List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: alexander.turenko@tarantool.org, tarantool-patches@dev.tarantool.org On 18:28 Sun 05 Jul , Vladislav Shpilevoy wrote: > > diff --git a/src/lua/msgpackffi.lua b/src/lua/msgpackffi.lua > > index f01ffaef0..cb7ad5b88 100644 > > --- a/src/lua/msgpackffi.lua > > +++ b/src/lua/msgpackffi.lua > > @@ -603,7 +599,7 @@ local function check_offset(offset, len) > > if offset == nil then > > return 1 > > end > > - local offset = ffi.cast('ptrdiff_t', offset) > > + offset = ffi.cast('ptrdiff_t', offset) > > Unnecessary diff. Reverted in a branch. > > if offset < 1 or offset > len then > > error(string.format("offset = %d is out of bounds [1..%d]", > > tonumber(offset), len))