From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtp62.i.mail.ru (smtp62.i.mail.ru [217.69.128.42])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id E8177445320
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 10 Jul 2020 13:49:44 +0300 (MSK)
Date: Fri, 10 Jul 2020 10:49:43 +0000
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200710104943.GA4625@tarantool.org>
References: <cover.1593096639.git.imeevma@gmail.com>
 <21d7145c1929bc4606c56e9a566477f248637ed1.1593096639.git.imeevma@gmail.com>
 <20200630115056.GA31599@tarantool.org>
 <20200705142656.GA135859@tarantool.org>
 <20200706212706.GB22427@tarantool.org>
 <5bbf04dc-addd-f188-f371-fba854f0a468@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <5bbf04dc-addd-f188-f371-fba854f0a468@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v3 2/8] sql: change implicit cast
	for assignment
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Mergen Imeev <imeevma@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On 07 Jul 12:29, Mergen Imeev wrote:
> 
> On 07.07.2020 00:27, Nikita Pettik wrote:
> > On 05 Jul 17:26, Mergen Imeev wrote:
> > > index 37283e506..bd0055668 100644
> > > --- a/src/box/sql/sqlInt.h
> > > +++ b/src/box/sql/sqlInt.h
> > > @@ -397,6 +397,15 @@ sql_value_to_diag_str(sql_value *value);
> > >   enum mp_type
> > >   sql_value_type(sql_value *);
> > > +/*
> > > + * Return the MP_type of the value of the MEM.
> > > + *
> > > + * @param mem MEM with the correct MEM_type.
> > > + * @retval MP_type of the value.
> > > + */
> > > +enum mp_type
> > > +mem_mp_type(struct Mem *mem);
> > Я вытащил добавление этой функции в отдельный патч и добавил
> > рефакторинг чтобы соеденить ее с sql_value_type().
> > https://github.com/tarantool/tarantool/tree/np/gh-3809-remastered
> > 
> > Если ты ОК, я пушну вне очереди в мастер.
> Я ОК.

Pushed to master as trivial refactoring.