From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <avtikhon@tarantool.org>
Received: from smtp60.i.mail.ru (smtp60.i.mail.ru [217.69.128.40])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 3B8F0445320
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 10 Jul 2020 12:26:36 +0300 (MSK)
Date: Fri, 10 Jul 2020 12:26:33 +0300
From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Message-ID: <20200710092633.GA4326@hpalx>
References: <e13d89eb48565441454348ce8ae816a2cf88307e.1593436970.git.avtikhon@tarantool.org>
 <20200703113230.kp3jnbzt5lsjk6lc@tkn_work_nb>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200703113230.kp3jnbzt5lsjk6lc@tkn_work_nb>
Subject: Re: [Tarantool-patches] [PATCH v1] build: fix static build w/
	dockerfile with cmake
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi Alexander, you are right, CMAKE_MODULE_PATH customization helped with
the issue. So the fix is moving to curl cmake build update.

On Fri, Jul 03, 2020 at 02:32:30PM +0300, Alexander Turenko wrote:
> > Closes #5019
> 
> Since it is now out of the patchset, where curl is build using cmake, it
> should be clarified that the problem only appears after switching curl
> to build using cmake.
> 
> > ---
> > 
> > Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-5019-findopenssl-dockerfile
> > Issue: https://github.com/tarantool/tarantool/issues/5019
> > 
> >  Dockerfile.staticbuild | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/Dockerfile.staticbuild b/Dockerfile.staticbuild
> > index 253f2d5e9..cb6c12e94 100644
> > --- a/Dockerfile.staticbuild
> > +++ b/Dockerfile.staticbuild
> > @@ -86,6 +86,8 @@ RUN set -x && \
> >           -DOPENSSL_USE_STATIC_LIBS=ON \
> >           -DOPENSSL_ROOT_DIR=/usr/local \
> >           . && \
> > +    sed 's%#define%#[\\t ]*define%g' -i \
> > +        /usr/share/cmake/Modules/FindOpenSSL.cmake && \
> >      make -j && make install
> 
> In fact it means that we'll not actually support cmake 2.8, not even
> 3.0 / 3.1, but only cmake since v3.1.1-1-gc5d9a8283c.
> 
> Can we pass custom CMAKE_MODULE_PATH with our cmake/ directory to curl?