From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp62.i.mail.ru (smtp62.i.mail.ru [217.69.128.42])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 9AE8A445320
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 10 Jul 2020 11:29:00 +0300 (MSK)
Date: Fri, 10 Jul 2020 11:28:59 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20200710082859.7jlbcsm4ukzvozxy@tarantool.org>
References: <3cdf11659eb18f79faecb65f4cbe25022a8d205e.1594312926.git.imeevma@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <3cdf11659eb18f79faecb65f4cbe25022a8d205e.1594312926.git.imeevma@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH v2 1/1] luarock: change a way to
 create manifest
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: imeevma@tarantool.org
Cc: yaroslav.dynnikov@tarantool.org, tarantool-patches@dev.tarantool.org

Hello,

On 09 июл 19:45, imeevma@tarantool.org wrote:
> Whenever a rock is installed it's being added to the repository
> manifest. And if a manifest doesn't exist yet, luarocks creates
> one by scanning the directory.
> 
> It causes a problem when *.all.rock with dependencies is installed
> into an empty directory. Luarocks unpacks the all.rock before
> installing dependencies, and it's modules are captured during
> manifest creation. After the installation finishes, luarocks adds
> the all.rock to the manifest once again (now intentionally),
> detects collision of module names and renames them uniquely, like
> "cartridge_1_2_0_1". As a result, "require()" function doesn't
> work.
> 
> This patch changes the way of manifest creation: instead of
> scanning repo luarocks creates an empty one.
> 
> Closes tarantool/tarantool#4704

I've checked your patch into tarantool/luarocks's tarantool-1.7
branch and bumped a new version in 1.10 branch.

--
Regards, Kirill Yukhin