From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f195.google.com (mail-lj1-f195.google.com [209.85.208.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E0D1E445320 for ; Fri, 10 Jul 2020 10:56:23 +0300 (MSK) Received: by mail-lj1-f195.google.com with SMTP id r19so5360204ljn.12 for ; Fri, 10 Jul 2020 00:56:23 -0700 (PDT) From: Cyrill Gorcunov Date: Fri, 10 Jul 2020 10:56:01 +0300 Message-Id: <20200710075605.217824-2-gorcunov@gmail.com> In-Reply-To: <20200710075605.217824-1-gorcunov@gmail.com> References: <20200710075605.217824-1-gorcunov@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH 1/5] qsync: eliminate redundant writes List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: tml Cc: Vladislav Shpilevoy Instead of updating is_sync variable on every cycle write it once. Signed-off-by: Cyrill Gorcunov --- src/box/txn.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/box/txn.c b/src/box/txn.c index a2df23833..49b2b2649 100644 --- a/src/box/txn.c +++ b/src/box/txn.c @@ -567,8 +567,12 @@ txn_journal_entry_new(struct txn *txn) if (stmt->row == NULL) continue; - is_sync = is_sync || (stmt->space != NULL && - stmt->space->def->opts.is_sync); + if (!is_sync) { + if (stmt->space != NULL && + stmt->space->def->opts.is_sync) { + is_sync = true; + } + } if (stmt->row->replica_id == 0) *local_row++ = stmt->row; -- 2.26.2