From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp32.i.mail.ru (smtp32.i.mail.ru [94.100.177.92]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 56A11445320 for ; Thu, 9 Jul 2020 11:39:06 +0300 (MSK) Date: Thu, 9 Jul 2020 11:39:05 +0300 From: Kirill Yukhin Message-ID: <20200709083905.hknbnpc4ibo7t544@tarantool.org> References: <20200629124419.23922-1-i.kosarev@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200629124419.23922-1-i.kosarev@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] xlog: make log directory if needed List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ilya Kosarev Cc: tarantool-patches@dev.tarantool.org Hello, On 29 июн 15:44, Ilya Kosarev wrote: > Tarantool's box.backup.start() returns the list of files needed to > successfully run new instance. The problem was that it doesn't include > empty indexes log directories. This means that after starting the > instance using backed up files and inserting something into previously > empty index we could run into log file creation error for example on > box.snapshot() call. Now this is not a problem as far as according > directories are created if needed. > > Closes #5090 > --- > Branch: https://github.com/tarantool/tarantool/tree/i.kosarev/gh-5027-fix-tuple-fields-nullability Wrong. > Issue: https://github.com/tarantool/tarantool/issues/5027 Wrong. > > @ChangeLog: > * Create missing folders for vinyl spaces and indexes if needed to > avoid confusing fails of tarantool started from backup. Need to mention an issue in brackets: (gh-5090). Otherwise LGTM. Fixed and checked into 1.10, 2.3, 2.4 and master. -- Regards, Kirill Yukhin