From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtp38.i.mail.ru (smtp38.i.mail.ru [94.100.177.98])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id CB5C9445320
 for <tarantool-patches@dev.tarantool.org>;
 Mon,  6 Jul 2020 17:02:12 +0300 (MSK)
Date: Mon, 6 Jul 2020 14:02:12 +0000
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200706140211.GA22427@tarantool.org>
References: <cover.1593096639.git.imeevma@gmail.com>
 <908f67730f9ab461531d61a66fe2c885be77682e.1593096639.git.imeevma@gmail.com>
 <20200628133131.GA23521@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200628133131.GA23521@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v3 1/8] sql: introduce
 mem_set_double()
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: imeevma@tarantool.org
Cc: tarantool-patches@dev.tarantool.org

On 28 Jun 13:31, Nikita Pettik wrote:
> On 25 Jun 18:17, imeevma@tarantool.org wrote:
> > The mem_set_double () function is used to properly set MEM as
> > containing DOUBLE value.
> 
> Nit: it has been introduced a long ago (sqlVdbeMemSetDouble()).
> You refactor it and use in several other places.
> 
> LGTM
>

I've fixed a bit commit message and pushed to master as trivial.

sql: refactor sqlVdbeMemSetDouble()

sqlVdbeMemSetDouble() function is used to properly set double value to
VDBE memory cell. Let's refactor it according to our codestyle and
rename it to mem_set_double() since we are going to use it instead of
raw mem's value modification.