From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id EA704445320 for ; Mon, 6 Jul 2020 13:34:50 +0300 (MSK) Date: Mon, 6 Jul 2020 13:24:35 +0300 From: Igor Munkin Message-ID: <20200706102435.GF5559@tarantool.org> References: <8c8cbc95-3d7b-6c92-669c-c040efdf8147@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <8c8cbc95-3d7b-6c92-669c-c040efdf8147@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] gdb: fix the extension to be loaded with Python 2 List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Oleg Babin Cc: tarantool-patches@dev.tarantool.org, Alexander Turenko Oleg, Thanks for your review! On 06.07.20, Oleg Babin wrote: > Hi! Thanks for your patch! > > I just add that problem appeared on CentOS 7 that is still popular. As I mentioned in the commit message the problem relates to gdb built against Python 2 (viz. 2.7.5, since I can't claim anything about later Python 2 versions). CentOS 7 is just particular distro providing this gdb and I guess one can install a new one from SCL. However, as we discussed with Sasha some time before it would be nice to support the toolchain provided by default. Thereby we should support Python 2 even after its EOL until CentOS 7 is gone. > > But seems your patch solves a problem. LGTM. Added your tag: | Reviewed-by: Oleg Babin > > > On 04/07/2020 22:58, Igor Munkin wrote: > > There was a mystic error when the extension was loaded against old gdb > > versions build against Python 2: Meh, this line looks bad, I've reworded it a bit: | There was a mystic error when the extension was loaded by the old gdb | versions built against Python 2: Updated the upstream. > > | (gdb) source luajit-gdb.py > > | Traceback (most recent call last): > > | File "luajit-gdb.py", line 702, in > > | load(None) > > | File "luajit-gdb.py", line 699, in load > > | 'lj-gc': LJGC, > > | File "luajit-gdb.py", line 687, in init > > | command(name) > > | File "luajit-gdb.py", line 468, in __init__ > > | gdb.write('{} command initialized\n'.format(name)) > > | ValueError: sequence.index(x): x not in sequence -- Best regards, IM