From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp16.mail.ru (smtp16.mail.ru [94.100.176.153])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 19924445320
 for <tarantool-patches@dev.tarantool.org>;
 Mon,  6 Jul 2020 10:47:56 +0300 (MSK)
Date: Mon, 6 Jul 2020 10:47:55 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20200706074755.hg4usgyeftydfdma@tarantool.org>
References: <cover.1593696889.git.sergepetrenko@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <cover.1593696889.git.sergepetrenko@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v3 0/2] fix replication tx
 boundaries after local space rework
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org

Hello,

On 02 июл 16:39, Serge Petrenko wrote:
> https://github.com/tarantool/tarantool/issues/4928
> https://github.com/tarantool/tarantool/tree/sp/gh-4928-tx-boundary-fix-nop
> 
> Changes in v3:
>   - Instead of reordering rows in WAL, append
>     a dummy NOP row to the tx end when needed.
> 
> Serge Petrenko (2):
>   wal: fix tx boundaries
>   replication: append NOP as the last tx row

I've checked your patchset into 2.3, 2.4 and master.

--
Regards, Kirill Yukhin