From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp58.i.mail.ru (smtp58.i.mail.ru [217.69.128.38]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 0DFD9445320 for ; Mon, 6 Jul 2020 09:34:00 +0300 (MSK) Date: Mon, 6 Jul 2020 09:33:59 +0300 From: Kirill Yukhin Message-ID: <20200706063359.fp3f3dvjk3wd2dja@tarantool.org> References: <20200705115749.45407-1-sergepetrenko@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200705115749.45407-1-sergepetrenko@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] applier: fix tx boundary check for half-applied txns List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Serge Petrenko Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org Hello, On 05 июл 14:57, Serge Petrenko wrote: > In case there are 2 "new" instances, running tarantool 2.2+, > master and replica, and one "old" instance, running an earlier tarantool > version, in a full-mesh cluster, it may happen that the "new" replica > receives part of a tx from an "old" instance, and the remaining part > from a "new" instance. > > Since "new" instances preserve tx boundaries, "new" replica would skip > the tx remains assuming it has already applied the full tx if it has > applied the first tx row. This leads to gaps in "new" replica's WAL and > to skipping the remaining part of the tx forever. > > Fix this behaviour to apply the full tx even if it's beginning is > already applied in mixed clusters. > > Closes #5125 > --- > > https://github.com/tarantool/tarantool/issues/5125 > https://github.com/tarantool/tarantool/tree/sp/gh-5125-applier-tx-boundaries LGTM. I've checked your patch into 2.3, 2.4 and master. -- Regards, Kirill Yukhin