From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imeevma@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 0620B445320
 for <tarantool-patches@dev.tarantool.org>;
 Sun,  5 Jul 2020 17:50:25 +0300 (MSK)
Date: Sun, 5 Jul 2020 17:50:24 +0300
From: Mergen Imeev <imeevma@tarantool.org>
Message-ID: <20200705145024.GE135859@tarantool.org>
References: <cover.1593096639.git.imeevma@gmail.com>
 <7036302de87521b8f6bc240f74bae3397ea64d75.1593096639.git.imeevma@gmail.com>
 <20200629235217.GD27240@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200629235217.GD27240@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v3 7/8] sql: remove unused functions
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On Mon, Jun 29, 2020 at 11:52:17PM +0000, Nikita Pettik wrote:
> On 25 Jun 18:17, imeevma@tarantool.org wrote:
> > After previous patches, some functions and the ApplyType opcode
> > become unused, so this patch removes them.
> > 
> > Follow-up #4230
> > ---
> 
> Все еще можно нагрепать OP_ApplyType. Перепроверь.
> 
Fixed:

diff --git a/src/box/sql/sqlInt.h b/src/box/sql/sqlInt.h
index e7826519b..0879ccbfa 100644
--- a/src/box/sql/sqlInt.h
+++ b/src/box/sql/sqlInt.h
@@ -3863,7 +3863,7 @@ int sqlVarintLen(u64 v);
 #define putVarint    sqlPutVarint

 /**
- * Code an OP_ApplyType opcode that will force types
+ * Code an OP_ImplicitCast opcode that will force types
  * for given range of register starting from @reg.
  *
  * @param v VDBE.