From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imeevma@tarantool.org>
Received: from smtpng3.m.smailru.net (smtpng3.m.smailru.net [94.100.177.149])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 7CA4D445320
 for <tarantool-patches@dev.tarantool.org>;
 Sun,  5 Jul 2020 17:28:53 +0300 (MSK)
Date: Sun, 5 Jul 2020 17:28:51 +0300
From: Mergen Imeev <imeevma@tarantool.org>
Message-ID: <20200705142851.GB135859@tarantool.org>
References: <cover.1593096639.git.imeevma@gmail.com>
 <a090ea42e15a75ba23ec0ab0995a2a0cd0e88147.1593096639.git.imeevma@gmail.com>
 <20200629125630.GA27240@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200629125630.GA27240@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v3 4/8] sql: replace ApplyType by
 CheckType for IN operator
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Nikita Pettik <korablev@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On Mon, Jun 29, 2020 at 12:56:30PM +0000, Nikita Pettik wrote:
> On 25 Jun 18:17, imeevma@tarantool.org wrote:
> > index f7681640e..a2147b0e8 100755
> > --- a/test/sql-tap/in3.test.lua
> > +++ b/test/sql-tap/in3.test.lua
> > @@ -1,6 +1,6 @@
> >  #!/usr/bin/env tarantool
> >  test = require("sqltester")
> > -test:plan(29)
> > +test:plan(28)
> >  
> >  --!./tcltestrunner.lua
> >  -- 2007 November 29
> > @@ -322,18 +322,6 @@ test:do_test(
> >          -- </in3-3.2>
> >      })
> >  
> > -test:do_test(
> > -    "in3-3.3",
> > -    function()
> > -        -- Logically, numeric affinity is applied to both sides before
> > -        -- the comparison, but index can't be used.
> > -        return exec_neph(" SELECT x IN (SELECT b FROM t1) FROM t2 ")
> > -    end, {
> > -        -- <in3-3.3>
> > -        1, true
> > -        -- </in3-3.3>
> > -    })
> > -
> 
> I'd rather not drop this test. It's about scalar-numeric types
> interaction. Mb it is not the most suitable place for such test,
> but make sure this scenario is covered somewhere else.
> 
I added a few tests with SCALARS in 'sql: remove implicit
cast for comparison' commit. However, there is a lot
problems with SCALARS at the moment.

> The rest is OK as obvious.
>