From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp52.i.mail.ru (smtp52.i.mail.ru [94.100.177.112])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id DA96542EF5C
 for <tarantool-patches@dev.tarantool.org>;
 Sun,  5 Jul 2020 05:15:01 +0300 (MSK)
Date: Sun, 5 Jul 2020 05:14:13 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20200705021413.s7jv7ugavv53vqek@tkn_work_nb>
References: <cover.1591345474.git.runsfor@gmail.com>
 <d3de1c532af7b0b4ef107955a8b7f8cf1c363675.1591345474.git.runsfor@gmail.com>
 <36bc5d2e-1981-54ed-befa-095debab6805@tarantool.org>
 <FF623ED6-D428-4637-BF3F-26AC0B9598C0@gmail.com>
 <20200701001608.roz3fgqapgyqsonf@tkn_work_nb>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200701001608.roz3fgqapgyqsonf@tkn_work_nb>
Subject: Re: [Tarantool-patches] [PATCH 1/2] feedback: determine runtime
	platform info
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: =?utf-8?B?0JjQu9GM0Y8g0JrQvtC90Y7RhdC+0LI=?= <runsfor@gmail.com>
Cc: tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>

On Wed, Jul 01, 2020 at 03:16:10AM +0300, Alexander Turenko wrote:
> > +local function fill_in_platform_info(feedback)
> > +    feedback.os        = jit.os
> > +    feedback.arch      = jit.arch
> > +    feedback.is_docker = detect_docker_environment()
> > +end
> 
> Platform information may be grouped into its own category.
> 
> Nit: I would choose more English friendly name for the 'is_docker'
> property. Say, 'dockerized' or at least 'is_under_docker'.

Whether you'll agree with grouping and renaming or not, the patch LGTM.