From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com [209.85.208.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 3CD9740F3AE for ; Sat, 4 Jul 2020 10:30:41 +0300 (MSK) Received: by mail-lj1-f193.google.com with SMTP id q7so26221222ljm.1 for ; Sat, 04 Jul 2020 00:30:41 -0700 (PDT) Date: Sat, 4 Jul 2020 10:30:38 +0300 From: Cyrill Gorcunov Message-ID: <20200704073038.GK2256@grain> References: <20200703144526.522358-1-gorcunov@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Tarantool-patches] [PATCH 00/22] Use void type in empty arguments list List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tml , Alexander Turenko On Fri, Jul 03, 2020 at 11:23:17PM +0200, Vladislav Shpilevoy wrote: > Hi! > > Is there a measurement showing how this speeds up or reduces executable's > size anyhow? Before [cyrill@grain tarantool.git] size ./src/tarantool text data bss dec hex filename 6315490 41788 128920 6486198 62f8b6 ./src/tarantool After [cyrill@grain tarantool.git] size ./src/tarantool text data bss dec hex filename 6308034 41788 128920 6478742 62db96 ./src/tarantool (it is debug build) Note the .text is been shrunk. > > Talking of the patch - why did you change .cc files? AFAIK, in C++ > (void) and () are the same. Just no arguments. True, still we've a mess between () and (void) in cc files, so I unified the approach.