From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp37.i.mail.ru (smtp37.i.mail.ru [94.100.177.97])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 32F3442EF5C
 for <tarantool-patches@dev.tarantool.org>;
 Fri,  3 Jul 2020 14:33:20 +0300 (MSK)
Date: Fri, 3 Jul 2020 14:32:30 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20200703113230.kp3jnbzt5lsjk6lc@tkn_work_nb>
References: <e13d89eb48565441454348ce8ae816a2cf88307e.1593436970.git.avtikhon@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <e13d89eb48565441454348ce8ae816a2cf88307e.1593436970.git.avtikhon@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v1] build: fix static build w/
	dockerfile with cmake
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

> Closes #5019

Since it is now out of the patchset, where curl is build using cmake, it
should be clarified that the problem only appears after switching curl
to build using cmake.

> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-5019-findopenssl-dockerfile
> Issue: https://github.com/tarantool/tarantool/issues/5019
> 
>  Dockerfile.staticbuild | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Dockerfile.staticbuild b/Dockerfile.staticbuild
> index 253f2d5e9..cb6c12e94 100644
> --- a/Dockerfile.staticbuild
> +++ b/Dockerfile.staticbuild
> @@ -86,6 +86,8 @@ RUN set -x && \
>           -DOPENSSL_USE_STATIC_LIBS=ON \
>           -DOPENSSL_ROOT_DIR=/usr/local \
>           . && \
> +    sed 's%#define%#[\\t ]*define%g' -i \
> +        /usr/share/cmake/Modules/FindOpenSSL.cmake && \
>      make -j && make install

In fact it means that we'll not actually support cmake 2.8, not even
3.0 / 3.1, but only cmake since v3.1.1-1-gc5d9a8283c.

Can we pass custom CMAKE_MODULE_PATH with our cmake/ directory to curl?