From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergeyb@tarantool.org>
Received: from smtp41.i.mail.ru (smtp41.i.mail.ru [94.100.177.101])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 1175442EF5E
 for <tarantool-patches@dev.tarantool.org>;
 Fri,  3 Jul 2020 01:46:20 +0300 (MSK)
Date: Fri, 3 Jul 2020 01:46:18 +0300
From: Sergey Bronnikov <sergeyb@tarantool.org>
Message-ID: <20200702224618.GA4579@pony.bronevichok.ru>
References: <cover.1593723973.git.sergeyb@tarantool.org>
 <a96998cf89d5fd75eb5e40fc050bda9e29d04146.1593723973.git.sergeyb@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <a96998cf89d5fd75eb5e40fc050bda9e29d04146.1593723973.git.sergeyb@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 4/4] replication: add tests for sync
 replication with snapshots
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org, sergepetrenko@tarantool.org, gorcunov@gmail.com, lvasiliev@tarantool.org

Unfortunately .result file is not consistent with test source code and
due to this test failed. I have updated it to make test green. Applied
changes below, branch contains updated commit.

diff --git a/test/replication/qsync_snapshots.result b/test/replication/qsync_snapshots.result
index db98f87fd..61cb7164b 100644
--- a/test/replication/qsync_snapshots.result
+++ b/test/replication/qsync_snapshots.result
@@ -129,7 +129,7 @@ box.space.sync:drop()
  | ---
  | ...
 
--- [RFC, Snapshot generation] rolled back operations are not snapshotted
+-- [RFC, Snapshot generation] rolled back operations are not snapshotted.
 -- Testcase setup.
 test_run:switch('default')
  | ---
@@ -190,7 +190,7 @@ box.space.sync:drop()
  | ...
 
 -- [RFC, Snapshot generation] snapshot started on master, then rollback
--- arrived, expected snapshot abort
+-- arrived, expected snapshot abort.
 test_run:switch('default')
  | ---
  | - true
@@ -257,7 +257,7 @@ box.space.sync:drop()
  | ...
 
 -- [RFC, Snapshot generation] snapshot started on replica, then rollback
--- arrived, expected snapshot abort
+-- arrived, expected snapshot abort.
 test_run:switch('default')
  | ---
  | - true

Sergey

On 00:13 Fri 03 Jul , sergeyb@tarantool.org wrote:
> From: Sergey Bronnikov <sergeyb@tarantool.org>
> 
> Part of #5055
> ---
>  test/replication/qsync_snapshots.result   | 362 ++++++++++++++++++++++
>  test/replication/qsync_snapshots.test.lua | 132 ++++++++
>  2 files changed, 494 insertions(+)
>  create mode 100644 test/replication/qsync_snapshots.result
>  create mode 100644 test/replication/qsync_snapshots.test.lua