From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lf1-f42.google.com (mail-lf1-f42.google.com
 [209.85.167.42])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 4379F42F4AD
 for <tarantool-patches@dev.tarantool.org>;
 Thu,  2 Jul 2020 18:53:50 +0300 (MSK)
Received: by mail-lf1-f42.google.com with SMTP id t74so16549671lff.2
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 02 Jul 2020 08:53:50 -0700 (PDT)
Date: Thu, 2 Jul 2020 18:53:47 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200702155347.GJ2256@grain>
References: <20200629203134.30177-1-skaplun@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20200629203134.30177-1-skaplun@tarantool.org>
Subject: Re: [Tarantool-patches] [DRAFT v1] replication: track information
	about replica
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Sergey Kaplun <skaplun@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>

On Mon, Jun 29, 2020 at 11:31:34PM +0300, Sergey Kaplun wrote:
...
>  
> +static int
> +relay_on_state_f(struct trigger *trigger, void *event)
> +{

Sergey, I'll review the patch with more attention tomorrow, still
here are some notes which I can point early.

 - please don't name the trigger function with _f postfix, we usually
   do this for cord thread runners (I know here are a few exceptions
   but they are simply misnamed)

> +	struct relay *relay = (struct relay *)event;
> +	(void)trigger;

You can easily exit early

	if (relay_get_state(relay) == RELAY_OFF)
		return 0;

shifting the rest of the code left. Still up to you I do not insist.

> +	if (relay_get_state(relay) != RELAY_OFF) {
> +		struct replica *replica = relay_replica(relay);
> +		const struct tt_uuid *uuid = &replica->uuid;
> +		assert(replica_by_uuid(uuid) != NULL);
> +		assert(replica->id != REPLICA_ID_NIL);
> +		if (boxk(IPROTO_UPDATE, BOX_CLUSTER_ID, "[%u]["
> +		         "[%s%u%lf]" /* last row time */
> +		         "[%s%u%s]" /* vclock */
> +		         "[%s%u%s]" /* relay state */
> +		         "]",
> +		         (unsigned) replica->id,
> +		         "=", 3, relay_last_row_time(relay),
> +		         "=", 4, vclock_to_string(relay_vclock(relay)),
> +		         "=", 5, relay_get_state_str(relay)
> +		        ) != 0) {
> +			diag_raise();
> +		}

Do we really need to call diag_raise() here?

> +		int rc;
> +		switch (relay_get_state(relay)) {
...
> +		}
> +		if (rc != 0)
> +			diag_raise();

And here. IIRC usually triggers simply return -1 on error.
The left of the patch is trimmed for now.