From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-f66.google.com (mail-lf1-f66.google.com [209.85.167.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id EA40F41C5DC for ; Thu, 2 Jul 2020 18:37:45 +0300 (MSK) Received: by mail-lf1-f66.google.com with SMTP id t74so16516395lff.2 for ; Thu, 02 Jul 2020 08:37:45 -0700 (PDT) Date: Thu, 2 Jul 2020 18:37:43 +0300 From: Cyrill Gorcunov Message-ID: <20200702153743.GI2256@grain> References: <106b9cbcf8577d6e3afbde57b15bc11d366c108e.1593696889.git.sergepetrenko@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <106b9cbcf8577d6e3afbde57b15bc11d366c108e.1593696889.git.sergepetrenko@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v3 2/2] replication: append NOP as the last tx row List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Serge Petrenko Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org On Thu, Jul 02, 2020 at 04:39:51PM +0300, Serge Petrenko wrote: > Since we stopped sending local space operations in replication, the last > tx row has to be global in order to preserve tx boundaries on replica. > If the last row happens to be a local one, replica will never receive > the tx end marker, yielding the following errors: > `ER_UNSUPPORTED: replication does not support interleaving > transactions`. > > In order to fix the problem append a global NOP row at the tx end if > it happens to end on a local row. > > Follow-up #4114 > Closes #4928 I've been trying to find out better place for this allocation (or even use preallocated static one) but since we need to assign lsn later in wal code none of ideas work. Thus lets keep it this way. Reviewed-by: Cyrill Gorcunov