From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com
 [209.85.208.196])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 9CE7942EF5C
 for <tarantool-patches@dev.tarantool.org>;
 Thu,  2 Jul 2020 13:18:19 +0300 (MSK)
Received: by mail-lj1-f196.google.com with SMTP id h22so23996064lji.9
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 02 Jul 2020 03:18:19 -0700 (PDT)
Date: Thu, 2 Jul 2020 13:18:16 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200702101816.GF2256@grain>
References: <20200702095054.367131-1-gorcunov@gmail.com>
 <20200702095054.367131-3-gorcunov@gmail.com>
 <1ed0cd76-9a93-0235-a580-ec046d8a3a0b@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1ed0cd76-9a93-0235-a580-ec046d8a3a0b@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v3 2/3] lua/log: allow to use json
	formatter early
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Oleg Babin <olegrok@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>, yaroslav.dynnikov@gmail.com

On Thu, Jul 02, 2020 at 01:05:38PM +0300, Oleg Babin wrote:
> Hi! Thanks for your patch! LGTM! See one minor nitpick below. I hope you
> could just force-pushed proposed change.
> 
> On 02/07/2020 12:50, Cyrill Gorcunov wrote:
> >   -- Set value to log from box.cfg{}.
> > -local function box_api_cfg_set(key, value)
> > +local function box_api_cfg_set(cfg, key, value)
> >       local log_key = box2log_keys[key]
> > +    local aux_data
> 
> Seems this variable is unused and could be dropped.

Yeah, thanks! Already changed and force pushed.