From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergos@tarantool.org>
Received: from smtp63.i.mail.ru (smtp63.i.mail.ru [217.69.128.43])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 2414C41C5DD
 for <tarantool-patches@dev.tarantool.org>;
 Wed,  1 Jul 2020 18:56:01 +0300 (MSK)
Date: Wed, 1 Jul 2020 18:55:59 +0300
From: Sergey Ostanevich <sergos@tarantool.org>
Message-ID: <20200701155559.GA45053@tarantool.org>
References: <cover.1593472477.git.v.shpilevoy@tarantool.org>
 <889461570dc63dba919b19b620a481ead13c2d3a.1593472477.git.v.shpilevoy@tarantool.org>
 <ffabb492-fd7f-702d-1d16-d65628a5e4f4@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <ffabb492-fd7f-702d-1d16-d65628a5e4f4@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 01/19] replication: introduce
 space.is_sync option
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hi!

Thanks for the patch, LGTM.
Please, create corresponding doc tracker as we agreed to do it
independently.

Regards,
Sergos

On 01 Jul 01:00, Vladislav Shpilevoy wrote:
> On 30/06/2020 01:15, Vladislav Shpilevoy wrote:
> > Synchronous space makes every transaction, affecting its data,
> > wait until it is replicated on a quorum of replicas before it is
> > committed.
> > 
> > Part of #4844
> > Part of #5073
> > ---
> >  src/box/alter.cc                              |  5 ++
> >  src/box/lua/net_box.lua                       |  2 +
> >  src/box/lua/schema.lua                        |  3 +
> >  src/box/lua/space.cc                          |  5 ++
> >  src/box/space_def.c                           |  2 +
> >  src/box/space_def.h                           |  6 ++
> >  .../sync_replication_sanity.result            | 71 +++++++++++++++++++
> >  .../sync_replication_sanity.test.lua          | 29 ++++++++
> 
> Renamed to qsync_basic.test.lua. The old name was too long, and wasn't
> about just sanity checks, which are usually extremely simple.