From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com
 [209.85.208.193])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 5F22942EF5C
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 29 Jun 2020 16:37:42 +0300 (MSK)
Received: by mail-lj1-f193.google.com with SMTP id h19so18017458ljg.13
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 29 Jun 2020 06:37:42 -0700 (PDT)
Date: Mon, 29 Jun 2020 16:37:39 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200629133739.GC2256@grain>
References: <20200629112319.154909-1-gorcunov@gmail.com>
 <34d2d32a-eb7e-a6a4-d2c8-57448563f02b@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <34d2d32a-eb7e-a6a4-d2c8-57448563f02b@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 0/3] log: allow json formatter in
	boottime logger
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Oleg Babin <olegrok@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>, yaroslav.dynnikov@gmail.com

On Mon, Jun 29, 2020 at 03:50:00PM +0300, Oleg Babin wrote:
> Hi! Thanks for your patch. Looks good but I want to clarify one thing:
> 
> 
> ```
> 
> tarantool> log.cfg{log = 'syslog', format='json'}
> ---
> ...
> 
> ```
> 
> It works fine but seems such command should throw an error:
> 
> "json can't be used with syslog logger", isn't it?
> 
> It happened because "ffi.C.log_type()" returns "0" -- boot-time logger.

Good catch! Due to code structure this case is not covered.
I'll update the series and the test. Thanks a lot!!!