From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp41.i.mail.ru (smtp41.i.mail.ru [94.100.177.101])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 946C342EF5C
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 26 Jun 2020 16:51:58 +0300 (MSK)
Date: Fri, 26 Jun 2020 16:51:06 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20200626135106.4o7mraweajyd4izo@tkn_work_nb>
References: <cover.1590503508.git.avtikhon@tarantool.org>
 <b07b25b57cb46c9d1c618ee3c1bf9189b77c1525.1590503508.git.avtikhon@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <b07b25b57cb46c9d1c618ee3c1bf9189b77c1525.1590503508.git.avtikhon@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2 1/7] build: static build needs
	more cleanup in sources
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: Oleg Piskunov <o.piskunov@tarantool.org>, tarantool-patches@dev.tarantool.org

> diff --git a/Dockerfile.staticbuild b/Dockerfile.staticbuild
> index 253f2d5e9..f67f46f5e 100644
> --- a/Dockerfile.staticbuild
> +++ b/Dockerfile.staticbuild
> @@ -75,7 +75,7 @@ RUN set -x && \
>  RUN set -x && \
>      find . -name 'CMakeFiles' -type d -exec rm -rf {} + && \
>      find . -name 'CMakeCache.txt' -type f -delete && \
> -    rm -rf build
> +    rm -rf build test/small test/luajit-tap

What if I'll push a short-term branch that adds one more test directory?

I think that the directory should be cleaned up entirely (git clean for
sources and submodules). And it seems that it is done with [1], right?
Such spotted cleanup will insuperably fails in some cases.

Anyway, I don't have objections against this certain patch if it still
needed after [1], just noted that it necessary only because the overall
approach is not good.

[1]: https://github.com/tarantool/tarantool/issues/5036

WBR, Alexander Turenko.