From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp36.i.mail.ru (smtp36.i.mail.ru [94.100.177.96])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 487BD42EF5C
 for <tarantool-patches@dev.tarantool.org>;
 Fri, 26 Jun 2020 12:46:18 +0300 (MSK)
Date: Fri, 26 Jun 2020 12:46:12 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20200626094612.kth2zmpoq2l2s4l3@tarantool.org>
References: <cover.1592458150.git.avtikhon@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <cover.1592458150.git.avtikhon@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v1 0/4] Fix app/digest and
	app/socket on 1.10
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, Alexander Turenko <alexander.turenko@tarantool.org>

Hello,

On 18 июн 08:36, Alexander V. Tikhonov wrote:
> Needed to port fixes from master for #4090 and commit the following:
> 
> 1.  Before the patch unicode characters encoded with 4 bytes
>     were always treated as non-printable and displayed as byte
>     sequences (with 'binary' tag).
>     With the patch, range of printable characters is extended and
>     include characters encoded with 4 bytes.
>     Currently it is: (old printable range) U (icu printable range).
>     Corresponding changes are also made in tarantool/libyaml.
>     
>     Closes: #4090
>     
>     (cherry picked from commit cdf37876189fa005a350d6b69397348354bb2073)
> 
> 2.  Bump libyaml
>     
>     Bumped libyaml with the following commits:
>     
>       7f41d551a44a9b947dc341dd5b6c8779b5d83f00 'Make sure libyaml is C89 compliant'
>       f1d1e5e0a5f6e6adeebe0e2c5e95a6ee729426e4 'cmake: make sure yaml is built statically when used in tarantool'
>       74a00faf5c4c8720149f7a726a5eda5e8fff86df 'Extend range of printable unicode characters'
>     
>     Needed for #4090
> 
> 3.  build: remove libyaml from rpm/deb dependencies
>     
>     After we started using bundled version of libyaml by default (see commit
>     47b91e90f2a4e23e70a1a6735af3de203ffd59f4), we can remove it from
>     building dependencies for RPM and DEB packages.
>     
>     Closes #4442
>     
>     Reviewed-by: Alexander Turenko <alexander.turenko@tarantool.org>
>     (cherry picked from commit 1d4e584a7b5a5570486d7dfa6df82e664f8e0f95)
> 
> 4.  build: enable bundled libyaml for all systems.
> 
>     After we fixed bundled libyaml to correctly print 4-byte Unicode
>     characters, it is no longer compatible with the upstream version, so
>     enable building with bundled libyaml for every platform.
>     This way the tests will pass.
>     
>     Follow-up #4090
>     
>     (cherry picked from commit 47b91e90f2a4e23e70a1a6735af3de203ffd59f4)
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-5007-pack-yaml
> Issue: https://github.com/tarantool/tarantool/issues/5007
> 
> Alexander V. Tikhonov (1):
>   Bump libyaml
> 
> Ivan Koptelov (1):
>   Extend range of printable unicode characters
> 
> Serge Petrenko (2):
>   build: enable bundled libyaml for all systems.
>   build: remove libyaml from rpm/deb dependencies

I've checked updated patchset into 1.10.

--
Regards, Kirill Yukhin