From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp36.i.mail.ru (smtp36.i.mail.ru [94.100.177.96])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 5D39A4429E1
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 24 Jun 2020 02:56:43 +0300 (MSK)
Date: Wed, 24 Jun 2020 02:55:51 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20200623235551.xxoed5lf5akuwaom@tkn_work_nb>
References: <cover.1589321083.git.alexander.turenko@tarantool.org>
 <20200622101112.icx6oumbcvkn44bh@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200622101112.icx6oumbcvkn44bh@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 0/3] box.execute() and box.cfg()
 idempotence and locking
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Kirill Yukhin <kyukhin@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

On Mon, Jun 22, 2020 at 01:11:12PM +0300, Kirill Yukhin wrote:
> Hello,
> 
> On 13 май 01:18, Alexander Turenko wrote:
> > This patchset provides several fixes for box.execute() and box.cfg()
> > functions when they are called under various circumstances: when a
> > function is saved before box loading and called after it, when a
> > function is called during box loading.
> > 
> > Existence of this patchset does not mean that we'll not implement
> > https://github.com/tarantool/tarantool/issues/4726: I don't know whether
> > we will do or will not, but I intend to fix bugs in the existing code.
> > 
> > https://github.com/tarantool/tarantool/issues/4231
> > Totktonada/gh-4231-box-execute-idempotence
> > 
> > My review is not more sufficient, because I became co-author of the
> > patchset. Igor, can you, please, review it and pass to a second reviewer
> > (I suggest Vlad)?
> > 
> > Alexander Turenko (1):
> >   box: always wait box loading in box.execute()
> > 
> > Maria (2):
> >   box: check whether box is loaded in box.execute()
> >   box: always reconfigure box at non-first box.cfg()
> 
> I've checked your patchset into 2.3, 2.4 and master.

Pushed 'box: always reconfigure box at non-first box.cfg()' to 1.10.

Borrowed <box_is_configured> variable and related comments from 'box:
check whether box is loaded in box.execute()' to correctly apply the
change.

Added an entry to the future 1.10.7 release notes.

Note: Also fixed gh-4221 with gh-4231 in other release notes, I mistyped
it in [1]. Sorry.

[1]: https://lists.tarantool.org/pipermail/tarantool-patches/2020-June/017543.html

WBR, Alexander Turenko.