From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [217.69.128.41])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 1F9CE42EF5C
 for <tarantool-patches@dev.tarantool.org>;
 Tue, 23 Jun 2020 17:09:12 +0300 (MSK)
Date: Tue, 23 Jun 2020 17:08:22 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20200623140822.ki2u4siym7eh63yw@tkn_work_nb>
References: <cover.1592458150.git.avtikhon@tarantool.org>
 <20200618103946.74xbym5et57ypubo@tkn_work_nb>
 <20200622135838.GA1740@hpalx>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200622135838.GA1740@hpalx>
Subject: Re: [Tarantool-patches] [PATCH v1 0/4] Fix app/digest and
	app/socket on 1.10
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

> commit 6595e9fccfb3f52e9c551458cbe0285d651c812b
> Author: Alexander V. Tikhonov <avtikhon@tarantool.org>
> Date:   Thu Jun 18 01:55:58 2020 +0300
> 
>     Bump libyaml
>     
>     Set to use in libyaml tarantool-1.10 branch with the following
>     bumped commit:
>     
>       f1d1e5e0a5f6e6adeebe0e2c5e95a6ee729426e4 'cmake: make sure yaml is built statically when used in tarantool'

Nit: I would carry the line in the commit message.

Nit: I would use cherry-pick -x for picking commits from libyaml master
for tarantool-1.10 branch.

I guess a commit that fixes C89 build needed here too (ask Sergey P.
where he meet a problem with it).

Maybe it is better to place the libyaml update first, before enabling
bundling by default: this way looks more safe.

Other than that I have no objection.

LGTM. No need to re-review with me after the changes suggested above:
just carefully test it.

WBR, Alexander Turenko.