From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <avtikhon@tarantool.org>
Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [217.69.128.41])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 51C6342EF5C
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 22 Jun 2020 17:07:30 +0300 (MSK)
Date: Mon, 22 Jun 2020 17:07:28 +0300
From: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Message-ID: <20200622140728.GC1740@hpalx>
References: <4351b421b56115e2d8c35f60fdb5e8ba43a7b9fe.1592628521.git.avtikhon@tarantool.org>
 <baccd41a-e997-834d-5236-a04cfd522ff9@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <baccd41a-e997-834d-5236-a04cfd522ff9@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v2] test: flaky
	box/net.box_wait_connected_gh-3856
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, Alexander Turenko <alexander.turenko@tarantool.org>

Hi Vlad, thanks for your review, I've corrected the test as you
suggested, please check my comments below.

On Sun, Jun 21, 2020 at 05:50:10PM +0200, Vladislav Shpilevoy wrote:
> Hi! Thanks for the patch!
> 
> > diff --git a/test/box/net.box_wait_connected_gh-3856.result b/test/box/net.box_wait_connected_gh-3856.result
> > index 9234e6cb9..0ac6d8a0b 100644
> > --- a/test/box/net.box_wait_connected_gh-3856.result
> > +++ b/test/box/net.box_wait_connected_gh-3856.result
> > @@ -1,19 +1,22 @@
> >  net = require('net.box')
> >  ---
> >  ...
> > +test_run = require('test_run').new()
> > +---
> > +...
> >  --
> >  -- gh-3856: wait_connected = false is ignored.
> >  --
> > -c = net.connect('8.8.8.8:123456', {wait_connected = false})
> > ----
> > -...
> > -c
> > +do                                                            \
> > +    c = net.connect('8.8.8.8:1234', {wait_connected = false}) \
> > +    return c                                                  \
> 
> You said you grab all connection fields, but you don't. This
> construction is 100% the same as
> 
>     c = net.connect('8.8.8.8:1234', {wait_connected = false})
> 
> Without 'do', 'return', and 'end'. In the original fix from
> Alexander Tu. I see that he returned c.state, not just c.
> But since you may need to call close() anyway, you probably
> should return
> 
>     c, c.state
> 
> So as to print the second value and close the first value.
> Another option - wrap all that into a function. Which calls
> close() inside, and returns the state.
> 

Ok, I've updated the test with the new function for it.

> > +end
> >  ---
> >  - opts:
> >      wait_connected: false
> >    host: 8.8.8.8
> >    state: initial
> > -  port: '123456'
> > +  port: '1234'
> >  ...
> >  c:close()