From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp31.i.mail.ru (smtp31.i.mail.ru [94.100.177.91])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id CD88C42EF5C
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 22 Jun 2020 13:11:13 +0300 (MSK)
Date: Mon, 22 Jun 2020 13:11:12 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20200622101112.icx6oumbcvkn44bh@tarantool.org>
References: <cover.1589321083.git.alexander.turenko@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <cover.1589321083.git.alexander.turenko@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 0/3] box.execute() and box.cfg()
 idempotence and locking
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hello,

On 13 май 01:18, Alexander Turenko wrote:
> This patchset provides several fixes for box.execute() and box.cfg()
> functions when they are called under various circumstances: when a
> function is saved before box loading and called after it, when a
> function is called during box loading.
> 
> Existence of this patchset does not mean that we'll not implement
> https://github.com/tarantool/tarantool/issues/4726: I don't know whether
> we will do or will not, but I intend to fix bugs in the existing code.
> 
> https://github.com/tarantool/tarantool/issues/4231
> Totktonada/gh-4231-box-execute-idempotence
> 
> My review is not more sufficient, because I became co-author of the
> patchset. Igor, can you, please, review it and pass to a second reviewer
> (I suggest Vlad)?
> 
> Alexander Turenko (1):
>   box: always wait box loading in box.execute()
> 
> Maria (2):
>   box: check whether box is loaded in box.execute()
>   box: always reconfigure box at non-first box.cfg()

I've checked your patchset into 2.3, 2.4 and master.

--
Regards, Kirill Yukhin