From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <korablev@tarantool.org>
Received: from smtp14.mail.ru (smtp14.mail.ru [94.100.181.95])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id D81CD42F4AD
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 22 Jun 2020 11:48:39 +0300 (MSK)
Date: Mon, 22 Jun 2020 08:48:38 +0000
From: Nikita Pettik <korablev@tarantool.org>
Message-ID: <20200622084838.GB30686@tarantool.org>
References: <cover.1592397263.git.imeevma@gmail.com>
 <acf68a1445652420838bab1af03fbdb3a5121045.1592397263.git.imeevma@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <acf68a1445652420838bab1af03fbdb3a5121045.1592397263.git.imeevma@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH v2 2/7] sql: remove mem_apply_type()
	from OP_MakeRecord
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: imeevma@tarantool.org
Cc: tarantool-patches@dev.tarantool.org

On 17 Jun 15:36, imeevma@tarantool.org wrote:
> This patch removes type changing from OP_MakeRecord.

Please reflect user-visible changes in commit message.
 
> Part of #4230
> ---
>  src/box/sql/analyze.c       |  7 +------
>  src/box/sql/delete.c        |  8 ++------
>  src/box/sql/expr.c          |  8 +-------
>  src/box/sql/fk_constraint.c |  9 ++-------
>  src/box/sql/select.c        | 25 ++++++-------------------
>  src/box/sql/update.c        | 14 +++-----------
>  src/box/sql/vdbe.c          | 19 +------------------
>  test/sql-tap/in3.test.lua   |  4 ++--
>  8 files changed, 18 insertions(+), 76 deletions(-)
> 
> diff --git a/test/sql-tap/in3.test.lua b/test/sql-tap/in3.test.lua
> index e29db9d93..f7681640e 100755
> --- a/test/sql-tap/in3.test.lua
> +++ b/test/sql-tap/in3.test.lua
> @@ -354,7 +354,7 @@ test:do_test(
>          return exec_neph(" SELECT y IN (SELECT a FROM t1) FROM t2 ")
>      end, {
>          -- <in3-3.5>
> -        1, true
> +        1, false
>          -- </in3-3.5>
>      })
>  
> @@ -378,7 +378,7 @@ test:do_test(
>          return exec_neph(" SELECT y IN (SELECT c FROM t1) FROM t2 ")
>      end, {
>          -- <in3-3.7>
> -        1, true
> +        1, false
>          -- </in3-3.7>
>      })
>  
> -- 
> 2.25.1
>