From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id C489042EF5C for ; Sun, 21 Jun 2020 22:18:35 +0300 (MSK) Date: Sun, 21 Jun 2020 22:09:24 +0300 From: Igor Munkin Message-ID: <20200621190924.GD3503@tarantool.org> References: <7b8e95f3d6da39f0c3c6ca742abccddda817ac5e.1592597647.git.imun@tarantool.org> <4150e5b8-b4c0-7151-d06e-a61d81eff97b@tarantool.org> <20200620212449.GB3503@tarantool.org> <9d73cfb2-99f5-1d1c-b337-3858b697c631@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <9d73cfb2-99f5-1d1c-b337-3858b697c631@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH 2/2] box: reduce box_process_lua Lua GC memory usage List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tarantool-patches@dev.tarantool.org Vlad, On 21.06.20, Vladislav Shpilevoy wrote: > > diff --git a/src/box/lua/call.c b/src/box/lua/call.c > > index e1b1a5e81..e52f16ca4 100644 > > --- a/src/box/lua/call.c > > +++ b/src/box/lua/call.c > > @@ -48,6 +48,15 @@ > > #include "mpstream/mpstream.h" > > #include "box/session.h" > > > > +/* > > Please, change to /**. In out of function comments we use /** > as a comment start. Yes, it's mentioned in commenting example[1] but I see license comment doesn't conform these guidelines. Nevertheless, I fixed, squashed, force-pushed to the branch. Diff is below: ================================================================================ diff --git a/src/box/lua/call.c b/src/box/lua/call.c index e52f16ca4..c3c60a4aa 100644 --- a/src/box/lua/call.c +++ b/src/box/lua/call.c @@ -48,7 +48,7 @@ #include "mpstream/mpstream.h" #include "box/session.h" -/* +/** * Handlers identifiers to obtain lua_Cfunction reference from * Lua registry table. These handlers are initialized on Tarantool * startup and are used until the Lua universe is destroyed. ================================================================================ > > > + * Handlers identifiers to obtain lua_Cfunction reference from > > + * Lua registry table. These handlers are initialized on Tarantool > > + * startup and are used until the Lua universe is destroyed. > > + * Such approach reduces Lua GC usage since there is no need to > > + * create short-lived GCfunc objects for the corresponding C > > + * function on each iproto CALL/EVAL request or stored Lua > > + * procedure call. > > + */ [1]: https://www.tarantool.io/en/doc/2.3/dev_guide/c_style_guide/#commenting-style -- Best regards, IM