From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com
 [209.85.208.193])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id C4FBF41C5DA
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 18 Jun 2020 17:46:56 +0300 (MSK)
Received: by mail-lj1-f193.google.com with SMTP id z9so7534912ljh.13
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 18 Jun 2020 07:46:56 -0700 (PDT)
Date: Thu, 18 Jun 2020 17:46:53 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200618144653.GR134822@grain>
References: <cover.1592482315.git.sergepetrenko@tarantool.org>
 <c019cb4048fc6cf26c4b5c9f0ac80ae0e0fa96d6.1592482315.git.sergepetrenko@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <c019cb4048fc6cf26c4b5c9f0ac80ae0e0fa96d6.1592482315.git.sergepetrenko@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 2/4] xrow: add ability to
	encode/decode ROLLBACK requests
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Serge Petrenko <sergepetrenko@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, v.shpilevoy@tarantool.org

> diff --git a/src/box/xrow.c b/src/box/xrow.c
> index 896e001b7..7a79a18dd 100644
> --- a/src/box/xrow.c
> +++ b/src/box/xrow.c
> @@ -879,7 +879,8 @@ xrow_encode_dml(const struct request *request, struct region *region,
>  }
>  
>  int
> -xrow_encode_confirm(struct xrow_header *row, uint32_t replica_id, int64_t lsn)
> +xrow_encode_confirm_rollback(struct xrow_header *row, uint32_t replica_id,
> +			     int64_t lsn)
>  {

Should not it be a static function?