From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lj1-f196.google.com (mail-lj1-f196.google.com
 [209.85.208.196])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id C0FFB42EF5D
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 18 Jun 2020 01:03:55 +0300 (MSK)
Received: by mail-lj1-f196.google.com with SMTP id x18so4818919lji.1
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 17 Jun 2020 15:03:55 -0700 (PDT)
From: Cyrill Gorcunov <gorcunov@gmail.com>
Date: Thu, 18 Jun 2020 01:03:30 +0300
Message-Id: <20200617220335.836265-2-gorcunov@gmail.com>
In-Reply-To: <20200617220335.836265-1-gorcunov@gmail.com>
References: <20200617220335.836265-1-gorcunov@gmail.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Subject: [Tarantool-patches] [PATCH 1/6] box: drop inline from box_cfg_xc
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: tml <tarantool-patches@dev.tarantool.org>
Cc: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, Alexander Turenko <alexander.turenko@tarantool.org>

There is serious "inline disease" in the code:
it spread left and right without a serious reason.

The box_cfg_xc function is a pretty big one and
doesn't require being inlined anyhow.

Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
---
 src/box/box.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/box/box.cc b/src/box/box.cc
index 96557651b..7c8b70b27 100644
--- a/src/box/box.cc
+++ b/src/box/box.cc
@@ -2373,7 +2373,7 @@ box_is_configured(void)
 	return is_box_configured;
 }
 
-static inline void
+static void
 box_cfg_xc(void)
 {
 	/* Join the cord interconnect as "tx" endpoint. */
-- 
2.26.2