From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp15.mail.ru (smtp15.mail.ru [94.100.176.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 4E2E042F4AD for ; Tue, 16 Jun 2020 13:41:22 +0300 (MSK) Date: Tue, 16 Jun 2020 13:41:21 +0300 From: Kirill Yukhin Message-ID: <20200616104121.tdzy3vd66ge7v5gc@tarantool.org> References: <20200611221844.6511-1-i.kosarev@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200611221844.6511-1-i.kosarev@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v2] memtx: fix tuples references on concurrent replaces List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Ilya Kosarev Cc: tarantool-patches@dev.tarantool.org Hello, On 12 июн 01:18, Ilya Kosarev wrote: > Since 527b02a2ee6a9a205d8e2c8f38bbb84edf0d6557 (memtx: add yields > during index build) memtx_build_on_replace was introduced to handle > concurrent updates. The problem here was that the tuples being handled > with this trigger did not get reference counter promotion, leading to a > number of wrong behavior cases. Now this problem is solved. > This problem was found through primary index altering with updates in > background fiber. Corresponding test is introduced. > > Closes #4973 > --- > Branch: https://github.com/tarantool/tarantool/tree/i.kosarev/gh-4973-segfaults-on-alter > Issue: https://github.com/tarantool/tarantool/issues/4973 LGTM. I've checked your patch into 2.3, 2.4 and master. -- Regards, Kirill Yukhin