From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [94.100.177.94])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id ED3A442F4AD
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 15 Jun 2020 01:23:37 +0300 (MSK)
Date: Mon, 15 Jun 2020 01:22:54 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20200614222254.blduhmzlgv2cfbba@tkn_work_nb>
References: <20200316121548.48251-1-arkholga@tarantool.org>
 <20200427170936.GO11314@tarantool.org>
 <cc96d61a-7bc5-e001-2e23-bf5d784921af@tarantool.org>
 <20200525122847.GH5455@tarantool.org>
 <85045cdc-ff4e-f1a1-7fb4-dbe67bb38160@tarantool.org>
 <20200526085907.GJ5455@tarantool.org>
 <a4e60859-7776-9989-79bf-6996e3d1452f@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <a4e60859-7776-9989-79bf-6996e3d1452f@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] cmake: set CMP0037 policy to NEW by
 default
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Olga Arkhangelskaia <arkholga@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

LGTM.

Pushed to master and 2.4. Several minor comments below.

WBR, Alexander Turenko.

On Wed, May 27, 2020 at 01:15:35PM +0300, Olga Arkhangelskaia wrote:
> Hi Igor!
> 
> Thanks for the review:
> 
> I have changed the order and left a small comment, so the diff looks like:
> 
> -if(CMAKE_VERSION VERSION_LESS 3.11)
> -    if(POLICY CMP0037)
> +if (POLICY CMP0037)
> +    # https://cmake.org/cmake/help/v3.11/release/3.11.html#other-changes
> +    # cmake below 3.11 reserves name test. Use old politics.

Nit: AFAIU, 'politics' and 'policy' are not synonyms: the former is more
about goverment actions (see [1]).

> +    if (CMAKE_VERSION VERSION_LESS 3.11)
>          cmake_policy(SET CMP0037 OLD)
> -    endif(POLICY CMP0037)
> -else()
> -    if(POLICY CMP0037)
> +    else()
> +        # Starting from cmake 3.11 name test reserved in special cases and
> can
> +        # be used as target name.

Nit: We usually fit our comments within 66 symbols (except URIs).

>          cmake_policy(SET CMP0037 NEW)
> -    endif(POLICY CMP0037)
> +    endif()
>  endif()

I don't see those changes on the branch [2]. Anyway, I applied those
changes manually and changes according to the comments above, pushed it
to master and 2.4 and removed the branch.

[1]: https://dictionary.cambridge.org/us/grammar/british-grammar/politics-political-politician-or-policy
[2]: OKriw/gh-3587-CMP0037-OLD-cmake-deprecation-warning-full-ci