From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp40.i.mail.ru (smtp40.i.mail.ru [94.100.177.100])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id A895641C5DB
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 15 Jun 2020 00:35:36 +0300 (MSK)
Date: Mon, 15 Jun 2020 00:34:51 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20200614213451.bf3dadnmqxsozfn6@tkn_work_nb>
References: <20200611002510.35349-1-huston.mavr@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200611002510.35349-1-huston.mavr@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH] cmake: cleanup src/CMakeLists.txt
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: HustonMmmavr <huston.mavr@gmail.com>
Cc: tarantool-patches@dev.tarantool.org, Vladislav Shpilevoy <v.shpilevoy@tarantool.org>, yaroslav.dynnikov@gmail.com

LGTM.

Vlad, can you look at the patch?

WBR, Alexander Turenko.

On Thu, Jun 11, 2020 at 03:25:10AM +0300, HustonMmmavr wrote:
> Removed definition and initialization of EXPORT_LIST variable at file
> src/CMakeLists.txt. After patch 03790ac551 this variable is unused
> (no reference to this variable after its initialization can be found
> in whole project) and it is only misleading.
> 
> Closes #5066

I would also mark it as follow up for #2971.

> ---
> I've builded tarantool before applying this changes and after.
> Then I've checked difference in tarantool binary file symbols with 
> nm and diff commands and there was no difference.
> 
> Issue: https://github.com/tarantool/tarantool/issues/5066
> Branch: https://github.com/tarantool/tarantool/tree/HustonMmmavr/gh-5066-delete-unusued-export-list
> 
> @ChangeLog
> - Cleanup src/CMakeLists.txt (gh-5066)

This change is not visible for a user, so I would not add a changelog
entry for it.