From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lj1-f181.google.com (mail-lj1-f181.google.com [209.85.208.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D47E742EF5C for ; Thu, 11 Jun 2020 23:12:39 +0300 (MSK) Received: by mail-lj1-f181.google.com with SMTP id z9so8446115ljh.13 for ; Thu, 11 Jun 2020 13:12:39 -0700 (PDT) Date: Thu, 11 Jun 2020 23:12:36 +0300 From: Cyrill Gorcunov Message-ID: <20200611201236.GQ134822@grain> References: <20200421213930.28713-1-gorcunov@gmail.com> <20200610075257.GO134822@grain> <20200611194316.GP134822@grain> <616766fd-204e-805e-bb19-2ed2e06e73ec@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <616766fd-204e-805e-bb19-2ed2e06e73ec@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH] fio/coio: handle partial writes List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: tml On Thu, Jun 11, 2020 at 09:56:31PM +0200, Vladislav Shpilevoy wrote: > > If you mean to merge into master branch -- I don't have such rights ;) > > Aha, so you changed the branch, but didn't say it anywhere. I was > looking at the branch you specified in the cover letter. Just a note - > better do a force push on the same branch. Having all these v1, v2, v15, > does not simplify the review. Even when you mention branch change in > one of the emails, still during the active review process with lots of > emails this one could be lost, and people would review the old branch > accidentally. Sorry for confusing you. I did it on a purpose -- I never do a force push until everything is settle down, mostly for history reason and to keep old changes and being able to make a diff between branches. Also I sent a new version as a separate email. Still I'll mark for myself that you prefer a force push instead and will try to follow this rule next time. Thanks for review! And sorry again for confusion.