From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtpng2.m.smailru.net (smtpng2.m.smailru.net [94.100.179.3]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id 6B02442EF5C for ; Thu, 11 Jun 2020 19:58:33 +0300 (MSK) Date: Thu, 11 Jun 2020 19:49:24 +0300 From: Igor Munkin Message-ID: <20200611164924.GS5745@tarantool.org> References: <20200610094354.31831-1-arkholga@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20200610094354.31831-1-arkholga@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH v2 0/2] console: support of backslash List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Olga Arkhangelskaia Cc: tarantool-patches@dev.tarantool.org, alexander.turenko@tarantool.org Olya, Thanks for the series! I left all patch-related comments in the corresponding replies. Here are also a couple not related to the code but the patchset itself. On 10.06.20, Olga Arkhangelskaia wrote: > @ChangeLog > While using local console one can use '\' to carry the line without > setting the delimiter. > Works only with local console. I guess the last line can be dropped, since you've already mentioned local console in the first line. Also please add the issue at the end of the sentence. > > Changes v2: > Added test case Minor: Please look how the changes between versions should be listed in our contribution guide[1] (or in your previous patches). > > Olga (1): This looks like a mess with the author both here and on the remote branch. Please fix it before the patch is applied to the stable ones. > test: add libisatty to test local console > > Olga Arkhangelskaia (1): > console: add line carrying backslash > > src/box/lua/console.lua | 18 ++++++++----- > test/CMakeLists.txt | 8 ++++++ > test/app-tap/gh-4317.test.lua | 51 +++++++++++++++++++++++++++++++++++ > test/isatty.c | 5 ++++ > 4 files changed, 76 insertions(+), 6 deletions(-) > create mode 100755 test/app-tap/gh-4317.test.lua > create mode 100644 test/isatty.c > > -- > 2.20.1 (Apple Git-117) > [1]: https://www.tarantool.io/en/doc/2.2/dev_guide/developer_guidelines/ -- Best regards, IM