From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <imun@tarantool.org>
Received: from smtpng1.m.smailru.net (smtpng1.m.smailru.net [94.100.181.251])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256
 bits)) (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id A6E1442EF5C
 for <tarantool-patches@dev.tarantool.org>;
 Thu, 11 Jun 2020 19:57:07 +0300 (MSK)
Date: Thu, 11 Jun 2020 19:47:58 +0300
From: Igor Munkin <imun@tarantool.org>
Message-ID: <20200611164758.GQ5745@tarantool.org>
References: <20200610094354.31831-1-arkholga@tarantool.org>
 <20200610094354.31831-2-arkholga@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200610094354.31831-2-arkholga@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 1/2] test: add libisatty to test
	local console
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Olga Arkhangelskaia <arkholga@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org, alexander.turenko@tarantool.org

Olya,

Thanks for the patch! I see no reason to introduce this auxiliary
library as a separate patch. Please consider some nits below.

On 10.06.20, Olga Arkhangelskaia wrote:
> From: Olga <arkholga@tarantool.org>
> 
> Local console is impossible to test within pipe, tatantool -i.

Typo: s/within/with/.
Typo: s/tatantool/tarantool/.

Minor: it's worth to describe the exact behaviour preventing tarantool
start with interactive console (i.e. isatty check) and mention the
issue[1] confirming that such behaviour is not OK.

> isatty lib was added to overcome isatty check and test local console.

Typo: s/overcome/overload/.

> Hack by Alexandr Turenko.

Minor: I failed to find such practice in our repo. If you want to
mention Sasha as author of this way to test local console, I guess you
can just add a Co-authored-by tag (if Sasha doesn't mind).

I also think, it's worth to mention the issue that motivates this patch.
Something like "Needed for #4317" is enough.

> ---
>  test/CMakeLists.txt | 8 ++++++++
>  test/isatty.c       | 5 +++++

Minor: it's better to place this library to test/app-tap directory. In
this case it simply doesn't spoil the root one.

>  2 files changed, 13 insertions(+)
>  create mode 100644 test/isatty.c
> 

<snipped>

> -- 
> 2.20.1 (Apple Git-117)
> 

[1]: https://github.com/tarantool/tarantool/issues/5064

-- 
Best regards,
IM