From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp54.i.mail.ru (smtp54.i.mail.ru [217.69.128.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id A467042EF5C for ; Thu, 11 Jun 2020 18:18:54 +0300 (MSK) From: Roman Khabibov Date: Thu, 11 Jun 2020 18:18:51 +0300 Message-Id: <20200611151853.24398-1-roman.habibov@tarantool.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: [Tarantool-patches] [PATCH v3 0/2] Use-unify-pattern-for-column-names List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: tarantool-patches@dev.tarantool.org Cc: v.shpilevoy@tarantool.org I decided to drop a patch to remove the append to the names "_N". The problem was much deeper than I thought. I have not yet been able to write a sane patch for distinguishing columns with the same name from different tables in a certain kind of queries. I'll do it in a separate branch later. Branch: https://github.com/tarantool/tarantool/tree/romanhabibov/gh-3962-column Issue: https://github.com/tarantool/tarantool/issues/3962 @ChangeLog - Name all automatically generated column with the pattern "COLUMN_N". - Fix a little bug with span display. Roman Khabibov (2): sql: use unify pattern for column names sql: print span more properly src/box/sql/select.c | 52 +-- src/box/sql/sqlInt.h | 15 + test/box/function1.result | 12 +- test/sql-tap/colname.test.lua | 106 +++++- test/sql-tap/select1.test.lua | 21 +- test/sql-tap/select6.test.lua | 22 +- test/sql-tap/view.test.lua | 4 +- test/sql/bind.result | 42 +-- test/sql/boolean.result | 354 +++++++++---------- test/sql/collation.result | 14 +- test/sql/errinj.result | 2 +- test/sql/foreign-keys.result | 4 +- test/sql/full_metadata.result | 18 +- test/sql/func-recreate.result | 2 +- test/sql/gh-3199-no-mem-leaks.result | 24 +- test/sql/gh-3888-values-blob-assert.result | 8 +- test/sql/gh-4697-scalar-bool-sort-cmp.result | 4 +- test/sql/icu-upper-lower.result | 82 ++--- test/sql/integer-overflow.result | 14 +- test/sql/iproto.result | 18 +- test/sql/max-on-index.result | 6 +- test/sql/misc.result | 12 +- test/sql/persistency.result | 66 ++-- test/sql/prepared.result | 36 +- test/sql/row-count.result | 40 +-- test/sql/transition.result | 66 ++-- test/sql/types.result | 224 ++++++------ 27 files changed, 688 insertions(+), 580 deletions(-) -- 2.21.0 (Apple Git-122)