From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [217.69.128.41])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 3B53F42EF5C
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 10 Jun 2020 17:00:39 +0300 (MSK)
Date: Wed, 10 Jun 2020 17:00:38 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20200610140038.cakjpgjlo4hlkbut@tarantool.org>
References: <20200610124701.13055-1-roman.habibov@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200610124701.13055-1-roman.habibov@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH] sql: display collation in metadata
 for scalar
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Roman Khabibov <roman.habibov@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

Hello,

Thanks for the patch. Few nits inlined.

Where is ChangeLog entry?

Fix it and it will be LGTM.

On 10 июн 15:47, Roman Khabibov wrote:
> Fix bug with the  display of collation for scalar fields in

Double space.

> <SELECT> result, when sql_full_metadata is enabled.
> 
> Closes #4755
> ---
> 
> Branch: https://github.com/tarantool/tarantool/tree/romanhabibov/gh-4755-scalar-collation
> Issue: https://github.com/tarantool/tarantool/issues/4755
> 
>  src/box/sql/select.c                          |  7 +--
>  .../gh-4755-scalar-collation-metadata.result  | 52 +++++++++++++++++++
>  ...gh-4755-scalar-collation-metadata.test.lua | 18 +++++++
>  3 files changed, 74 insertions(+), 3 deletions(-)
>  create mode 100644 test/sql/gh-4755-scalar-collation-metadata.result
>  create mode 100755 test/sql/gh-4755-scalar-collation-metadata.test.lua
> 
> diff --git a/test/sql/gh-4755-scalar-collation-metadata.result b/test/sql/gh-4755-scalar-collation-metadata.result
> new file mode 100644
> index 000000000..eef2d86ad
> --- /dev/null
> +++ b/test/sql/gh-4755-scalar-collation-metadata.result
> @@ -0,0 +1,52 @@
> +-- test-run result file version 2
> +env = require('test_run')
> + | ---
> + | ...
> +test_run = env.new()
> + | ---
> + | ...
> +
> +--
> +-- gh-4755: Collation in metadata must be displayed as for string
> +-- filed as for scalar field.

Start with lowercase, please. Re-phrase it: "... for both string and scalar field types ..."

--
Regards, Kirill Yukhin