From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp63.i.mail.ru (smtp63.i.mail.ru [217.69.128.43])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 33D92469710
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 10 Jun 2020 12:20:53 +0300 (MSK)
Date: Wed, 10 Jun 2020 12:20:52 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20200610092052.624uezv4ebqx7j3k@tarantool.org>
References: <20200526151747.93659-1-huston.mavr@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200526151747.93659-1-huston.mavr@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH] static build: fix build on ubuntu
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: HustonMmmavr <huston.mavr@gmail.com>
Cc: tarantool-patches@dev.tarantool.org, alexander.turenko@tarantool.org

Hello,

On 26 май 18:17, HustonMmmavr wrote:
> Fixed static build with '-DBUILD_STATIC=ON' option:
> 
> * Added cmake option CMAKE_DL_LIBS to icu library for
>   test/unit tests binaries builds at file:
>     cmake/FindICU.cmake
>   due to fail:
>     [ 84%] Linking CXX executable vy_point_lookup.test
>     /usr/local/lib/libicuuc.a(putil.ao): In function `uprv_dl_open_62':
>     putil.cpp:(.text+0x1a22): undefined reference to `dlopen'
>     /usr/local/lib/libicuuc.a(putil.ao): In function `uprv_dlsym_func_62':
>     putil.cpp:(.text+0x1a7d): undefined reference to `dlsym'
>     /usr/local/lib/libicuuc.a(putil.ao): In function `uprv_dl_close_62':
>     putil.cpp:(.text+0x1a61): undefined reference to `dlclose'
>     collect2: error: ld returned 1 exit status
> 
> * Added cmake option CMAKE_DL_LIBS to gomp library for
>   test/unit tests binaries builds at file:
>     cmake/BuildMisc.cmake
>   due to fail:
>     [ 91%] Linking CXX executable bps_tree.test
>     /usr/lib/gcc/x86_64-linux-gnu/7/libgomp.a(target.o): In function `gomp_target_init':
>     (.text+0x8b): undefined reference to `dlopen'
>     (.text+0xa2): undefined reference to `dlsym'
>     (.text+0xd9): undefined reference to `dlclose'
>     (.text+0x29b): undefined reference to `dlsym'
>     (.text+0x2a8): undefined reference to `dlerror'
>     (.text+0x2d0): undefined reference to `dlsym'
>     (.text+0x2e9): undefined reference to `dlsym'
>     (.text+0x300): undefined reference to `dlsym'
>     (.text+0x317): undefined reference to `dlsym'
>     (.text+0x330): undefined reference to `dlsym'
>     /usr/lib/gcc/x86_64-linux-gnu/7/libgomp.a(target.o):(.text+0x34d): more undefined references to `dlsym' follow
>     /usr/lib/gcc/x86_64-linux-gnu/7/libgomp.a(target.o): In function `gomp_target_init':
>     (.text+0x9cc): undefined reference to `dlerror'
>     collect2: error: ld returned 1 exit status
> 
> Close #5024
> ---
> Issue: https://github.com/tarantool/tarantool/issues/5024
> Branch: https://github.com/tarantool/tarantool/tree/HustonMmmavr/gh-5024-static-build-ubuntu

I've checked your patch into 1.10, 2.3, 2.4 and master.

--
Regards, Kirill Yukhin