From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergos@tarantool.org>
Received: from smtp61.i.mail.ru (smtp61.i.mail.ru [217.69.128.41])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 17DEE469710
 for <tarantool-patches@dev.tarantool.org>;
 Wed, 10 Jun 2020 12:18:15 +0300 (MSK)
Date: Wed, 10 Jun 2020 12:18:14 +0300
From: Sergey Ostanevich <sergos@tarantool.org>
Message-ID: <20200610091814.GH50@tarantool.org>
References: <cover.1591701695.git.sergepetrenko@tarantool.org>
 <20200609125302.279888-2-gorcunov@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200609125302.279888-2-gorcunov@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH 1/2] box/applier: fix typo
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>, v.shpilevoy@tarantool.org

Hi!

Thanks for the catch! 

LGTM
Sergos.


On 09 июн 15:53, Cyrill Gorcunov wrote:
> fixup 3210e1e6f867cfd1c1f65e05f28a32deae63c172
> 
> Signed-off-by: Cyrill Gorcunov <gorcunov@gmail.com>
> ---
>  src/box/applier.cc | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/box/applier.cc b/src/box/applier.cc
> index 1dc977424..cf7215d43 100644
> --- a/src/box/applier.cc
> +++ b/src/box/applier.cc
> @@ -271,7 +271,7 @@ applier_on_confirm(struct trigger *trig, void *data)
>  static int
>  process_confirm(struct request *request)
>  {
> -	assert(request->header->type = IPROTO_CONFIRM);
> +	assert(request->header->type == IPROTO_CONFIRM);
>  	uint32_t replica_id;
>  	struct txn *txn = in_txn();
>  	int64_t *lsn = (int64_t *) region_alloc(&txn->region, sizeof(int64_t));
> -- 
> 2.26.2
>