From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp3.mail.ru (smtp3.mail.ru [94.100.179.58]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id D2EBF469710 for ; Tue, 9 Jun 2020 19:17:15 +0300 (MSK) Date: Tue, 9 Jun 2020 19:16:05 +0300 From: Sergey Bronnikov Message-ID: <20200609161605.GC67772@pony.bronevichok.ru> References: <7a3dac5d-b4a6-a9b9-2f0e-076e46f6a38f@tarantool.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <7a3dac5d-b4a6-a9b9-2f0e-076e46f6a38f@tarantool.org> Subject: Re: [Tarantool-patches] [PATCH 1/6] Add initial luacheck config List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Vladislav Shpilevoy Cc: alexander.turenko@tarantool.org, tarantool-patches@dev.tarantool.org Hi, thanks for review! On 20:02 Sat 06 Jun , Vladislav Shpilevoy wrote: > Hi! Thanks for the patch! > > On 04/06/2020 10:39, sergeyb@tarantool.org wrote: > > From: Sergey Bronnikov > > > > config includes all files with Lua source code except: > > Lets start sentences from capital letters. > > > - third_party repositories > > - directories with diff-based tests > > Seems like src/* is excluded. So nothing is checked, and the > commit message is wrong. Agree, removed section "how-to" in a commit message. Next commit brings target 'luacheck' and it's commit message self-explain how to execute static analysis. > I see, that you turn on the checks in next commits, but then the > commit message should be changed. > > > How-to check: > > > > $ luacheck --codes --config .luacheckrc . > > > > Part of #4681 > > > > Reviewed-by: Vladislav Shpilevoy > > Co-authored-by: Vladislav Shpilevoy -- sergeyb@