From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp46.i.mail.ru (smtp46.i.mail.ru [94.100.177.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dev.tarantool.org (Postfix) with ESMTPS id E132D469710 for ; Tue, 9 Jun 2020 14:49:10 +0300 (MSK) Date: Tue, 9 Jun 2020 14:49:10 +0300 From: Kirill Yukhin Message-ID: <20200609114910.7idlcug3eqeybsgo@tarantool.org> References: <20200608153042.55274-1-khdmitryi@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200608153042.55274-1-khdmitryi@gmail.com> Subject: Re: [Tarantool-patches] [PATCH] error: use int64_t as reference counter List-Id: Tarantool development patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Dmitry Khominich Cc: tarantool-patches@dev.tarantool.org Hello, On 08 июн 18:30, Dmitry Khominich wrote: > Before it was unsafe to use error.prev, box.error.last(), or any error > method that increments error reference counter. Any of them could throw a > Lua error in case of INT32_MAX overflow. > > This patch uses int64_t as error reference counter making it impossible > to get counter overflow. > > Closes #4902 > --- > Branch: https://github.com/dmitryikh/tarantool/tree/error_ref_to_int64 > Issue: https://github.com/tarantool/tarantool/issues/4902 I've checked your patch into 2.4 and master. -- Regards, Kirill Yukhin