From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergeyb@tarantool.org>
Received: from smtp34.i.mail.ru (smtp34.i.mail.ru [94.100.177.94])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 9B9A8469710
 for <tarantool-patches@dev.tarantool.org>;
 Mon,  8 Jun 2020 18:38:47 +0300 (MSK)
Date: Mon, 8 Jun 2020 18:37:39 +0300
From: Sergey Bronnikov <sergeyb@tarantool.org>
Message-ID: <20200608153739.GC53062@pony.bronevichok.ru>
References: <cover.1590053781.git.sergeyb@tarantool.org>
 <0efa478f960af63eca977f5c3d9615c87197ccc5.1590053781.git.sergeyb@tarantool.org>
 <bb3f8990-587d-0130-408c-6850126477bb@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <bb3f8990-587d-0130-408c-6850126477bb@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 1/2] test: update unit test lib to
 produce TAP-compliant output
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Vladislav Shpilevoy <v.shpilevoy@tarantool.org>
Cc: o.piskunov@tarantool.org, tarantool-patches@dev.tarantool.org, Alexander Turenko <alexander.turenko@tarantool.org>

Hi, Vladislav

thanks for spending time on review of my patches!

On 00:52 Thu 04 Jun , Vladislav Shpilevoy wrote:
> Thanks for the patch!
> 
> > diff --git a/test/unit/unit.h b/test/unit/unit.h
> > index 43c301b28..27879ea98 100644
> > --- a/test/unit/unit.h
> > +++ b/test/unit/unit.h
> > @@ -129,6 +126,16 @@ int check_plan(void);
> >  	}						\
> >  }
> >  
> > +#define header() do {				\
> > +	_space(stdout);				\
> > +	printf("# *** %s ***\n", __func__);	\
> > +} while(0)
> > +
> > +#define footer() do {					\
> > +	_space(stdout);					\
> > +	printf("# *** %s: done ***\n", __func__);	\
> 
> Since alignment is used, lets use it correctly. And align all
> the slashes in the same way.

Fixed.

> I mean footer and header slashes. Slightly screwed tabs inside
> footer and inside header macros are git diff artifacts, no problem
> here.
> 
> > +} while(0)
> > +
> >  #if defined(__cplusplus)
> >  }
> >  #endif /* defined(__cplusplus) */

-- 
sergeyb@