From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gorcunov@gmail.com>
Received: from mail-lj1-f193.google.com (mail-lj1-f193.google.com
 [209.85.208.193])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 99ECB469710
 for <tarantool-patches@dev.tarantool.org>;
 Mon,  8 Jun 2020 18:33:11 +0300 (MSK)
Received: by mail-lj1-f193.google.com with SMTP id a25so21046993ljp.3
 for <tarantool-patches@dev.tarantool.org>;
 Mon, 08 Jun 2020 08:33:11 -0700 (PDT)
Date: Mon, 8 Jun 2020 18:33:08 +0300
From: Cyrill Gorcunov <gorcunov@gmail.com>
Message-ID: <20200608153308.GK134822@grain>
References: <20200608104450.157253-1-gorcunov@gmail.com>
 <20200608104450.157253-2-gorcunov@gmail.com>
 <e731a0e8-1268-c1d4-6093-c32169e7ca5e@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <e731a0e8-1268-c1d4-6093-c32169e7ca5e@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH 1/3] lua/cfg: drop unused log methods
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Oleg Babin <olegrok@tarantool.org>
Cc: tml <tarantool-patches@dev.tarantool.org>

On Mon, Jun 08, 2020 at 06:29:25PM +0300, Oleg Babin wrote:
> Hi! Thanks for your patch. See 1 comment below.
...
> 
> I assume that "box_set_log_level" and "box_set_log_format" should be removed
> as well.

Nope, they are called when we modify dynamic settings via box.cfg{}.