From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <sergeyb@tarantool.org>
Received: from smtp40.i.mail.ru (smtp40.i.mail.ru [94.100.177.100])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 2A1FF469710
 for <tarantool-patches@dev.tarantool.org>;
 Mon,  8 Jun 2020 18:32:19 +0300 (MSK)
Date: Mon, 8 Jun 2020 18:31:11 +0300
From: Sergey Bronnikov <sergeyb@tarantool.org>
Message-ID: <20200608153111.GA53062@pony.bronevichok.ru>
References: <e0f00f4f70d21f8ae251ed5dd73b403257c65440.1589883920.git.sergeyb@tarantool.org>
 <20200603172711.2dmy5bfekkzhi4as@tkn_work_nb>
 <20200604130703.GC19065@pony.bronevichok.ru>
 <20200608091958.twb4dmv4zeaqtlfe@tkn_work_nb>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200608091958.twb4dmv4zeaqtlfe@tkn_work_nb>
Subject: Re: [Tarantool-patches] [PATCH v2] Add option to update file with
	reference output
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Alexander Turenko <alexander.turenko@tarantool.org>
Cc: o.piskunov@tarantool.org, tarantool-patches@dev.tarantool.org

Hi,

Alexander, I send a new version of patches with fixes after review.

On 12:19 Mon 08 Jun , Alexander Turenko wrote:
> Sergey, please squash fixup commits before sending a next version of a
> patchset to review.
> 
> Please, put flake8 configuration update first: so each commit will pass
> CI.

put it first on updated patchset

> The 'new' status disappears in the new patchset version. Can you look at
> this again? It looks as unintentional change.

Yeah, my bad. Fixed it.

> > -            elif not self.is_crash_reported and not self.is_equal_result:
> > +            elif (not self.is_crash_reported and not self.is_equal_result):
> 
> Please, avoid unneeded diffs.

reverted change

> WBR, Alexander Turenko.

-- 
sergeyb@