From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp56.i.mail.ru (smtp56.i.mail.ru [217.69.128.36])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 4838D469710
 for <tarantool-patches@dev.tarantool.org>;
 Mon,  8 Jun 2020 16:32:34 +0300 (MSK)
Date: Mon, 8 Jun 2020 16:32:19 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20200608133219.e6ew5xibgtljjgaj@tkn_work_nb>
References: <cover.1587577457.git.avtikhon@tarantool.org>
 <a4e3e096397448219d25a44772aee8bba9b20ce2.1587577457.git.avtikhon@tarantool.org>
 <20200425071730.hva3scyfskaraukr@tkn_work_nb>
 <20200513074000.GA971@hpalx>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <20200513074000.GA971@hpalx>
Subject: Re: [Tarantool-patches] [PATCH v2 2/3] gitlab-ci: add out-of-source
	build
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: tarantool-patches@dev.tarantool.org

While we discussing curl and so, there is clear fix re bootstrap.h. I'll
not mind if you'll send it within a separate patch.

On Wed, May 13, 2020 at 10:40:00AM +0300, Alexander V. Tikhonov wrote:
> Hi Alexander, thanks a lot for the review, please check my comments below.
> 
> On Sat, Apr 25, 2020 at 10:17:30AM +0300, Alexander Turenko wrote:
> > > index 5f8b15a63..753b7293a 100644
> > > --- a/cmake/BuildLibCURL.cmake
> > > +++ b/cmake/BuildLibCURL.cmake
> > > @@ -56,10 +56,10 @@ macro(curl_build)
> > >          DOWNLOAD_DIR ${LIBCURL_BINARY_DIR}
> > >          TMP_DIR ${LIBCURL_BINARY_DIR}/tmp
> > >          STAMP_DIR ${LIBCURL_BINARY_DIR}/stamp
> > > -        BINARY_DIR ${LIBCURL_BINARY_DIR}
> > > +        BINARY_DIR ${LIBCURL_BINARY_DIR}/curl
> > 
> > Don't get what is the problem you try to solve here.
> > 
> 
> The path to curl binaries is set here, which later used
> for configuring/building/installing and no need to write
> it there each time.

I'll try to ask it in other words. What is wrong with
LIBCURL_BINARY_DIR, which is ${PROJECT_BINARY_DIR}/build/curl/work now?
Okay, if something wrong, then shouldn't we set it to
${PROJECT_BINARY_DIR}/build/curl/work/curl right at initialization
(however I don't see a reason)?

Is not the reason https://github.com/curl/curl/pull/5213 ? Can we avoid
this change if we'll update the curl submodule?

WBR, Alexander TUrenko.