From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <kyukhin@tarantool.org>
Received: from smtp36.i.mail.ru (smtp36.i.mail.ru [94.100.177.96])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 00C6B469710
 for <tarantool-patches@dev.tarantool.org>;
 Mon,  8 Jun 2020 12:36:29 +0300 (MSK)
Date: Mon, 8 Jun 2020 12:36:24 +0300
From: Kirill Yukhin <kyukhin@tarantool.org>
Message-ID: <20200608093624.ehxwz7aq2zc4zpb6@tarantool.org>
References: <20200605185544.54436-1-gorcunov@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20200605185544.54436-1-gorcunov@gmail.com>
Subject: Re: [Tarantool-patches] [PATCH v9 0/2] lua/log: add an ability to
 setup logger without box.cfg{}
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: tml <tarantool-patches@dev.tarantool.org>

Hello,

On 05 июн 21:55, Cyrill Gorcunov wrote:
> In the series we add an ability to configure logger early without
> calling box.cfg{}. The syntax is the same as in box.cfg{} call.
> 
> There was an idea to implement something similar via triggers but
> I think this will require a way more efforts and code redesign,
> so at first lets stick to simplier solution.
> 
> I'm pretty sure we will be able to simplify and beautify code more later.
> 
> v9:
>  - complete reworking of the whole series
> 
> branch gorcunov/gh-689-logger-9
> issue https://github.com/tarantool/tarantool/issues/689
> 
> Cyrill Gorcunov (2):
>   lua/log: add ability to configure logging early
>   test: app-tap/logger -- test new modes

LGTM. I've checked your patch set into master.

--
Regards, Kirill Yukhin