From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <alexander.turenko@tarantool.org>
Received: from smtp29.i.mail.ru (smtp29.i.mail.ru [94.100.177.89])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dev.tarantool.org (Postfix) with ESMTPS id 52C4B469710
 for <tarantool-patches@dev.tarantool.org>;
 Sun,  7 Jun 2020 17:04:01 +0300 (MSK)
Date: Sun, 7 Jun 2020 17:03:46 +0300
From: Alexander Turenko <alexander.turenko@tarantool.org>
Message-ID: <20200607140346.kjcgjk3ufcmn4vmd@tkn_work_nb>
References: <624bfee981237f22842b083fb3e0093b9c06e780.1591536783.git.avtikhon@tarantool.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
In-Reply-To: <624bfee981237f22842b083fb3e0093b9c06e780.1591536783.git.avtikhon@tarantool.org>
Subject: Re: [Tarantool-patches] [PATCH v1] gitlab-ci: add packaging for
	Fedora 32
List-Id: Tarantool development patches <tarantool-patches.dev.tarantool.org>
List-Unsubscribe: <https://lists.tarantool.org/mailman/options/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=unsubscribe>
List-Archive: <https://lists.tarantool.org/pipermail/tarantool-patches/>
List-Post: <mailto:tarantool-patches@dev.tarantool.org>
List-Help: <mailto:tarantool-patches-request@dev.tarantool.org?subject=help>
List-Subscribe: <https://lists.tarantool.org/mailman/listinfo/tarantool-patches>, 
 <mailto:tarantool-patches-request@dev.tarantool.org?subject=subscribe>
To: "Alexander V. Tikhonov" <avtikhon@tarantool.org>
Cc: Oleg Piskunov <o.piskunov@tarantool.org>, tarantool-patches@dev.tarantool.org

On Sun, Jun 07, 2020 at 04:40:40PM +0300, Alexander V. Tikhonov wrote:
> Added packaging jobs for Fedora 32.
> 
> Closes #4966
> 
> (cherry picked from commit 5613beedf83a679b725cea816a4176eabe3e1601)

Are you added 'cherry picked from' by mistake?

> Also added job to travis-ci.
> ---
> 
> Github: https://github.com/tarantool/tarantool/tree/avtikhon/gh-4966-fedora-32-old-full-ci
> Issue: https://github.com/tarantool/tarantool/issues/4966
> 
> The patch should be committed only after commit
>   bdd90686f82ec2e22d4ea7adfb9a6173bcc8af4a
> will be pushed to be able to fix Fedoar 32 build.

It should not be pushed until all warnings from [1] will be resolved or
at least will be proven to be false-positive.

[1]: https://github.com/tarantool/tarantool/issues/4966

> 
> Also current fix is on for 1.10 branch only, for other branches
> need to make changes in .travis.yml changes:
> 2.4: 1.10 -> 2.4
> 2.3: 1.10 -> 2.3
> 2.2: 1.10 -> 2.2
> For master branch .travis.yml doesn't need to be updated.
> Use 5613beedf83a679b725cea816a4176eabe3e1601 for master branch.

I would rather implement the patch on top of master and mention what
should be done after cherry-picking for 2.4, 2.3 and 1.10.